Skip to content

Issue 53419: Aliquot parent with number like names that starts with leading zeroes aren't resolved during import - #6848

Merged
XingY merged 4 commits into
developfrom
fb_issue53419
Jul 17, 2025
Merged

Issue 53419: Aliquot parent with number like names that starts with leading zeroes aren't resolved during import#6848
XingY merged 4 commits into
developfrom
fb_issue53419

Conversation

@XingY

@XingY XingY commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Rationale

Issue 53419
When the values are number like, the column will be inferred as numeric types with leading zeros removed. Previous PRs had forced inputs and parent alias to be inferred as String types. This PR force aliquotedFrom to be inferred as String for sample imports.

Related Pull Requests

Changes

  • Force String type AliquotedFrom column inference for sample type import
  • Add jest integration test for issue

Tasks 📍

@XingY XingY self-assigned this Jul 15, 2025
@XingY
XingY requested a review from labkey-susanh July 16, 2025 19:51
@labkey-susanh

Copy link
Copy Markdown
Contributor

Testing notes

This is not related to this change:

If I provide the rowId of a sample (e.g., 4147339) instead of the name (Te-43474), the resulting aliquot name uses that rowId instead of the name (e.g., 4147339-1). Very much of an edge case as it is unlikely anyone will actually be providing rowIds in an import file and the solution is pretty simple (use the names instead), but if we do this via an API call, the results may be unexpected.

@XingY
XingY merged commit d37f052 into develop Jul 17, 2025
10 checks passed
@XingY
XingY deleted the fb_issue53419 branch July 17, 2025 15:51
@XingY

XingY commented Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

Testing notes

This is not related to this change:

If I provide the rowId of a sample (e.g., 4147339) instead of the name (Te-43474), the resulting aliquot name uses that rowId instead of the name (e.g., 4147339-1). Very much of an edge case as it is unlikely anyone will actually be providing rowIds in an import file and the solution is pretty simple (use the names instead), but if we do this via an API call, the results may be unexpected.

As discussed, this behavior is debatable, but it's consistent with other lineage input (MaterialInputs/Type) or lookup. User can use MaterialInputs/Type/Name to get name instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants